[PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

Sui Jingfeng suijingfeng at loongson.cn
Thu Jun 8 09:43:32 UTC 2023


Hi,  thanks for your reply and help.

On 2023/6/8 17:31, Andi Shyti wrote:
> Hi Jingfeng,
>
> On Thu, Jun 08, 2023 at 03:24:54PM +0800, Sui Jingfeng wrote:
>> Hi,
>>
>> thanks a lot
>>
>> On 2023/6/8 15:15, Paul Kocialkowski wrote:
>>> Hi,
>>>
>>> On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
>>>> drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
>>>> two kconfig option, otherwise the driver failed to compile on platform
>>>> without REGMAP_MMIO selected:
>>>>
>>>> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
>>>> make: *** [Makefile:1978: modpost] Error 2
>>>>
>>>> Signed-off-by: Sui Jingfeng <suijingfeng at loongson.cn>
>>> Thanks for the fix, looks good to me!
>>>
>>> Acked-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
>> After received this Acked-by, do a need append this tag to the patch, and
>> resend this again?
>>
>> I don't know about this.
>>
>> I don't need to do anythings ales, you will push it to your repository,
>> right?
> no need... someone will pick it up and add the needed tags.
Thanks a lot. Happy coding! :-)
> Andi

-- 
Jingfeng



More information about the dri-devel mailing list