[PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

[Laurent Pinchart]

On Mon, Jun 12, 2023 at 02:44:33PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 12, 2023 at 2:23 PM Laurent Pinchart wrote:
> > On Mon, Jun 12, 2023 at 09:53:02AM +0000, Biju Das wrote:
> > > Hi All,
> > >
> > > How do we proceed here between [1] and [2]?
> > >
> > > DT-Maintainers suggestion:
> > > [1]
> > > raa215300: pmic at 12 {
> > >       compatible = "renesas,raa215300";
> > >       reg = <0x12>, <0x6f>;
> > >       reg-names = "main", "rtc";
> > >
> > >       clocks = <&x2>;
> > >       clock-names = "xin";
> > >       /* Add Optional shared IRQ resource and share it to child and handle it both in parent and child */
> > > };
> > >
> > > Laurent/Wolfram suggestion to split it into two nodes and get rid of this patch:
> > > [2]
> > >       raa215300: pmic @12 {
> > >               compatible = "renesas,raa215300";
> > >               reg = <0x12>;
> > >
> > >               /* Add Optional shared IRQ */
> > >               renesas,raa215300-rtc = <&rtc_raa215300>; /* Parse the handle and Enable RTC , if present.*/
> > >       };
> > >
> > >       rtc_raa215300: rtc at 6f {
> > >               compatible = "renesas,raa215300-isl1208";
> >
> > Make this
> >
> >                 compatible = "renesas,raa215300-isl1208", "isil,isl1208";
> 
> "renesas,raa215300-rtc", "isil,isl1208".
> 
> However, that would suggest the RAA215300 RTC can be treated as
> an ISL1208, which is not true for all revisions...

It depends. If we add a renesas,invert-xtoscb DT property, then it
becomes true for all revisions.

> > Btw, it would be nice to convert
> > Documentation/devicetree/bindings/rtc/isil,isl1208.txt to YAML.
> 
> Hey, look at patch 2 in this series ;-)

-- 
Regards,

Laurent Pinchart