[PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

[Andrew Davis]

On 6/13/23 9:47 AM, Sarah Walker wrote:
> Add the device tree binding documentation for the Series AXE GPU used in
> TI AM62 SoCs.
> 
> Signed-off-by: Sarah Walker <sarah.walker at imgtec.com>
> ---
>   .../devicetree/bindings/gpu/img,powervr.yaml  | 71 +++++++++++++++++++
>   MAINTAINERS                                   |  7 ++
>   2 files changed, 78 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/gpu/img,powervr.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr.yaml
> new file mode 100644
> index 000000000000..652343876d1c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2022 Imagination Technologies Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/img,powervr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination Technologies PowerVR GPU
> +
> +maintainers:
> +  - Sarah Walker <sarah.walker at imgtec.com>
> +
> +properties:
> +  compatible:
> +    oneOf:

oneOf shouldn't be needed, you can just do the enum followed by const.

> +      - items:
> +          - enum:
> +              - ti,am62-gpu
> +          - const: img,powervr-seriesaxe
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 3
> +
> +  clock-names:
> +    items:
> +      - const: core
> +      - const: mem
> +      - const: sys
> +    minItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: GPU interrupt
> +
> +  interrupt-names:
> +    items:
> +      - const: gpu
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  power-supply: true

Why do you need power-supply?

Andrew

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +  - interrupt-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    gpu: gpu at fd00000 {
> +        compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> +        reg = <0x0fd00000 0x20000>;
> +        power-domains = <&some_pds 187>;
> +        clocks = <&k3_clks 187 0>;
> +        clock-names = "core";
> +        interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> +        interrupt-names = "gpu";
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b344e1318ac3..a41517843a10 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10084,6 +10084,13 @@ IMGTEC IR DECODER DRIVER
>   S:	Orphan
>   F:	drivers/media/rc/img-ir/
>   
> +IMGTEC POWERVR DRM DRIVER
> +M:	Frank Binns <frank.binns at imgtec.com>
> +M:	Sarah Walker <sarah.walker at imgtec.com>
> +M:	Donald Robson <donald.robson at imgtec.com>
> +S:	Supported
> +F:	Documentation/devicetree/bindings/gpu/img,powervr.yaml
> +
>   IMON SOUNDGRAPH USB IR RECEIVER
>   M:	Sean Young <sean at mess.org>
>   L:	linux-media at vger.kernel.org