[01/14] drm/ast: Fix DRAM init on AST2200

Sui Jingfeng suijingfeng at loongson.cn
Fri Jun 16 14:32:36 UTC 2023


On 2023/6/16 21:52, Thomas Zimmermann wrote:
> Fix the test for the AST2200 in the DRAM initialization. The value
> in ast->chip has to be compared against an enum constant instead of
> a numerical value.
>
> This bug got introduced when the driver was first imported into the
> kernel.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>

Reviewed-by: Sui Jingfeng <suijingfeng at loongson.cn>


> Fixes: 312fec1405dd ("drm: Initial KMS driver for AST (ASpeed Technologies) 2000 series (v2)")
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: dri-devel at lists.freedesktop.org
> Cc: <stable at vger.kernel.org> # v3.5+
> ---
>   drivers/gpu/drm/ast/ast_post.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c
> index a005aec18a020..0262aaafdb1c5 100644
> --- a/drivers/gpu/drm/ast/ast_post.c
> +++ b/drivers/gpu/drm/ast/ast_post.c
> @@ -291,7 +291,7 @@ static void ast_init_dram_reg(struct drm_device *dev)
>   				;
>   			} while (ast_read32(ast, 0x10100) != 0xa8);
>   		} else {/* AST2100/1100 */
> -			if (ast->chip == AST2100 || ast->chip == 2200)
> +			if (ast->chip == AST2100 || ast->chip == AST2200)
>   				dram_reg_info = ast2100_dram_table_data;
>   			else
>   				dram_reg_info = ast1100_dram_table_data;

-- 
Jingfeng



More information about the dri-devel mailing list