[PATCH v3 19/19] drm/msm/dpu: drop empty features mask INTF_SDM845_MASK

Marijn Suijten marijn.suijten at somainline.org
Fri Jun 16 23:03:29 UTC 2023


On 2023-06-16 13:03:17, Dmitry Baryshkov wrote:
> The INTF_SDM845_MASK features mask is zero. Drop it completely.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

Reviewed-by: Marijn Suijten <marijn.suijten at somainline.org>

> ---
>  drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 4 ----
>  drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h  | 4 ----
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c          | 2 --
>  3 files changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h
> index d78cedd35c01..060e6a49b2f9 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h
> @@ -246,7 +246,6 @@ static const struct dpu_intf_cfg msm8998_intf[] = {
>  	{
>  		.name = "intf_0", .id = INTF_0,
>  		.base = 0x6a000, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DP,
>  		.controller_id = MSM_DP_CONTROLLER_0,
>  		.prog_fetch_lines_worst_case = 21,
> @@ -256,7 +255,6 @@ static const struct dpu_intf_cfg msm8998_intf[] = {
>  	}, {
>  		.name = "intf_1", .id = INTF_1,
>  		.base = 0x6a800, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DSI,
>  		.controller_id = MSM_DSI_CONTROLLER_0,
>  		.prog_fetch_lines_worst_case = 21,
> @@ -266,7 +264,6 @@ static const struct dpu_intf_cfg msm8998_intf[] = {
>  	}, {
>  		.name = "intf_2", .id = INTF_2,
>  		.base = 0x6b000, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DSI,
>  		.controller_id = MSM_DSI_CONTROLLER_1,
>  		.prog_fetch_lines_worst_case = 21,
> @@ -276,7 +273,6 @@ static const struct dpu_intf_cfg msm8998_intf[] = {
>  	}, {
>  		.name = "intf_3", .id = INTF_3,
>  		.base = 0x6b800, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_HDMI,
>  		.prog_fetch_lines_worst_case = 21,
>  		.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h
> index de26f469ebb1..54d7475e1591 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h
> @@ -260,7 +260,6 @@ static const struct dpu_intf_cfg sdm845_intf[] = {
>  	{
>  		.name = "intf_0", .id = INTF_0,
>  		.base = 0x6a000, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DP,
>  		.controller_id = MSM_DP_CONTROLLER_0,
>  		.prog_fetch_lines_worst_case = 24,
> @@ -270,7 +269,6 @@ static const struct dpu_intf_cfg sdm845_intf[] = {
>  	}, {
>  		.name = "intf_1", .id = INTF_1,
>  		.base = 0x6a800, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DSI,
>  		.controller_id = MSM_DSI_CONTROLLER_0,
>  		.prog_fetch_lines_worst_case = 24,
> @@ -280,7 +278,6 @@ static const struct dpu_intf_cfg sdm845_intf[] = {
>  	}, {
>  		.name = "intf_2", .id = INTF_2,
>  		.base = 0x6b000, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DSI,
>  		.controller_id = MSM_DSI_CONTROLLER_1,
>  		.prog_fetch_lines_worst_case = 24,
> @@ -290,7 +287,6 @@ static const struct dpu_intf_cfg sdm845_intf[] = {
>  	}, {
>  		.name = "intf_3", .id = INTF_3,
>  		.base = 0x6b800, .len = 0x280,
> -		.features = INTF_SDM845_MASK,
>  		.type = INTF_DP,
>  		.controller_id = MSM_DP_CONTROLLER_1,
>  		.prog_fetch_lines_worst_case = 24,
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 4a18fc66a412..3efa22429e5f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -95,8 +95,6 @@
>  
>  #define DSPP_SC7180_MASK BIT(DPU_DSPP_PCC)
>  
> -#define INTF_SDM845_MASK (0)
> -
>  #define INTF_SC7180_MASK \
>  	(BIT(DPU_INTF_INPUT_CTRL) | \
>  	 BIT(DPU_INTF_TE) | \
> -- 
> 2.39.2
> 


More information about the dri-devel mailing list