[PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

Biju Das biju.das.jz at bp.renesas.com
Mon Jun 19 08:17:27 UTC 2023


Hi All,

> Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API
> 
> 
> > > Without of_node, devm_clk_get() and friends falls back to registered
> > > clkdevs. So you could call clk_register_clkdev() from within the
> > > PMIC driver, and can keep on using devm_clk_get_optional() in the
> > > ISL1208 driver.
> >
> > Seriously, how many hacks are we piling ? :-)
> 
> For this particular case, why do you consider this a hack? I previously
> suggested the solution that the PMIC driver exposes a clock to be consumed
> for the RTC driver even for the "two DT node solution". Because it then
> avoids a custom property with a phandle to the other node with regular DT
> clock bindings. I'd think we need sth like that in any case.

OK, Will use clk_register_clkdev() in PMIC driver, so that there is no code
change needed in RTC driver for clk handling.

Cheers,
Biju



More information about the dri-devel mailing list