[PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Thu Jun 22 18:37:51 UTC 2023


On 21/06/2023 02:23, Fabio Estevam wrote:
> From: Fabio Estevam <festevam at denx.de>
> 
> The adreno_is_a20x() and adreno_is_a225() functions rely on the
> GPU revision, but such information is retrieved inside adreno_gpu_init(),
> which is called afterwards.
> 
> Fix this problem by caling adreno_gpu_init() earlier, so that
> the GPU information revision is available when adreno_is_a20x()
> and adreno_is_a225() run.
> 
> Tested on a imx53-qsb board.
> 
> Fixes: 21af872cd8c6 ("drm/msm/adreno: add a2xx")
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
> Hi,
> 
> This error has been exposed by a recent commit in linux-next:
> 
> cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set")
> 
> , but the error has been present since the very first a2xx commit.
> 
> Changes since v2:
> - Call adreno_gpu_init() earlier.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>


> 
>   drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)


-- 
With best wishes
Dmitry



More information about the dri-devel mailing list