[PATCH] drm/ttm: fix warning that we shouldn't mix && and ||

Alex Deucher alexdeucher at gmail.com
Fri Jun 23 13:49:39 UTC 2023


On Fri, Jun 23, 2023 at 3:09 AM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> Trivial warning fix.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Fixes: 4481913607e5 ("drm/ttm: fix bulk_move corruption when adding a entry")

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/ttm/ttm_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
> index e51dbc7a2d53..46ff9c75bb12 100644
> --- a/drivers/gpu/drm/ttm/ttm_resource.c
> +++ b/drivers/gpu/drm/ttm/ttm_resource.c
> @@ -114,7 +114,7 @@ static void ttm_lru_bulk_move_del(struct ttm_lru_bulk_move *bulk,
>         struct ttm_lru_bulk_move_pos *pos = ttm_lru_bulk_move_pos(bulk, res);
>
>         if (unlikely(WARN_ON(!pos->first || !pos->last) ||
> -                    pos->first == res && pos->last == res)) {
> +                    (pos->first == res && pos->last == res))) {
>                 pos->first = NULL;
>                 pos->last = NULL;
>         } else if (pos->first == res) {
> --
> 2.34.1
>


More information about the dri-devel mailing list