[PATCH] drm/tests: Fix swapped test parameter names
Maira Canal
mairacanal at riseup.net
Sat Jun 24 19:45:36 UTC 2023
Hi Carlos,
Great catch!
On 6/23/23 12:25, Carlos Eduardo Gallo Filho wrote:
> The "YVU420 DRM_MODE_FB_MODIFIERS set without modifier" test
> hadn't DRM_MODE_FB_MODIFIERS set, so that it was in fact testing
> another case, while the "YVU420 Normal sizes" test in turn was with
> DRM_MODE_FB_MODIFIERS set and without modifiers, what should be
> the case tested by the former, which also in turn fit in what
> "YVU320 Normal sizes" should be, meaning that they were swapped.
>
> Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos at disroot.org>
With André's comment addressed,
Reviewed-by: Maíra Canal <mairacanal at riseup.net>
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/tests/drm_framebuffer_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> index df235b7fdaa5..f759d9f3b76e 100644
> --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
> +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> @@ -178,13 +178,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
> .handles = { 1, 1, 1 }, .pitches = { 600, 600, 600 },
> }
> },
> -{ .buffer_created = 1, .name = "YVU420 Normal sizes",
> +{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier",
> .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420,
> .handles = { 1, 1, 1 }, .flags = DRM_MODE_FB_MODIFIERS,
> .pitches = { 600, 300, 300 },
> }
> },
> -{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier",
> +{ .buffer_created = 1, .name = "YVU420 Normal sizes",
> .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420,
> .handles = { 1, 1, 1 }, .pitches = { 600, 300, 300 },
> }
More information about the dri-devel
mailing list