[PATCH] drm/vram-helper: turn on PRIME import/export

[Thomas Zimmermann]

Hi

Am 01.03.23 um 23:29 schrieb Simon Ser:
> We don't populate gem_prime_import_sg_table so only DMA-BUFs
> exported from our own device can be imported. Still, this is useful
> to user-space.

VRAM helpers don't really offer much flexibility or control in where to 
place a BO. What happens if the BO is located in device video ram and 
cannot be used by the other participant? A blank screen?

I'd also consider VRAM helpers as deprecated. The remaining few drivers 
can be converted to SHMEM helpers; except maybe bochs could get its own 
TTM-based memory management.

Best regards
Thomas

> 
> Signed-off-by: Simon Ser <contact at emersion.fr>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Tian Tao <tiantao6 at hisilicon.com>
> Cc: Maxime Ripard <maxime at cerno.tech>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Hans de Goede <hdegoede at redhat.com>
> ---
>   include/drm/drm_gem_vram_helper.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_gem_vram_helper.h b/include/drm/drm_gem_vram_helper.h
> index d3e8920c0b64..f4aab64411d8 100644
> --- a/include/drm/drm_gem_vram_helper.h
> +++ b/include/drm/drm_gem_vram_helper.h
> @@ -160,7 +160,9 @@ void drm_gem_vram_simple_display_pipe_cleanup_fb(
>   	.debugfs_init             = drm_vram_mm_debugfs_init, \
>   	.dumb_create		  = drm_gem_vram_driver_dumb_create, \
>   	.dumb_map_offset	  = drm_gem_ttm_dumb_map_offset, \
> -	.gem_prime_mmap		  = drm_gem_prime_mmap
> +	.gem_prime_mmap		  = drm_gem_prime_mmap, \
> +	.prime_handle_to_fd	  = drm_gem_prime_handle_to_fd, \
> +	.prime_fd_to_handle	  = drm_gem_prime_fd_to_handle
>   
>   /*
>    *  VRAM memory manager

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230302/b903c43c/attachment.sig>