[PATCH 2/2] habanalabs: use scnprintf() in print_device_in_use_info()

Stanislaw Gruszka stanislaw.gruszka at linux.intel.com
Thu Mar 2 10:25:29 UTC 2023


On Thu, Mar 02, 2023 at 11:15:17AM +0200, Oded Gabbay wrote:
> From: Tomer Tayar <ttayar at habana.ai>
> 
> compose_device_in_use_info() was added to handle the snprintf() return
> value in a single place.
> However, the buffer size in print_device_in_use_info() is set such that
> it would be enough for the max possible print, so
> compose_device_in_use_info() is not really needed.
> Moreover, scnprintf() can be used instead of snprintf(), to save the
> check if the return value larger than the given size.
> 
> Cc: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
> Signed-off-by: Tomer Tayar <ttayar at habana.ai>
> Reviewed-by: Oded Gabbay <ogabbay at kernel.org>
> Signed-off-by: Oded Gabbay <ogabbay at kernel.org>

Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>


More information about the dri-devel mailing list