On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote: > + } > } > > + BUG_ON(!pstate); > nvkm_debug(subdev, "setting performance state %d\n", pstatei); > clk->pstate = pstatei; We should probably also replace this with if (WARN_ON(!pstate) return -EINVAL; -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat