[PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Mar 8 10:52:41 UTC 2023


On 08/03/2023 05:36, Dixit, Ashutosh wrote:
> On Mon, 06 Mar 2023 03:10:24 -0800, Tvrtko Ursulin wrote:
>>
> 
> Hi Tvrtko,
> 
>> On 04/03/2023 01:27, Ashutosh Dixit wrote:
>>> SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from
>>
>> Would it be more accurate to say 'SLPC does not use rps->cur_freq' rather
>> than it not using struct intel_rps?
> 
> No actually SLPC maintains a separate 'struct intel_guc_slpc' and does not
> use 'struct intel_rps' at all so all of 'struct intel_rps' is 0.

I keep forgetting how there is zero code / data sharing with all this.. :(

>> Fixes: / stable ? CI chances of catching this?
> 
> Same issue as Patch 1, I have answered this there.

Okay lets see it clarified there.

Regards,

Tvrtko


More information about the dri-devel mailing list