[PATCH v13 03/10] drm/display: Add Type-C switch helpers
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Wed Mar 8 15:28:54 UTC 2023
On Wed, Mar 08, 2023 at 06:20:14PM +0800, Pin-yen Lin wrote:
> On Mon, Mar 6, 2023 at 7:49 PM Andy Shevchenko
> > On Fri, Mar 03, 2023 at 10:33:43PM +0800, Pin-yen Lin wrote:
...
> > > + switch_desc->typec_ports = devm_kcalloc(dev, switch_desc->num_typec_switches,
> > > + sizeof(struct drm_dp_typec_port_data),
> > > + GFP_KERNEL);
> > > + if (!switch_desc->typec_ports)
> > > + return -ENOMEM;
> >
> > How often this function _can_ be called during the runtime?
> > If it's _possible_ to call it infinite times, consider *not* using devm.
>
> I would expect this function to be only called during driver probing,
> and this is the case for the current users in this series. So I think
> this is only called once if EPROBDE_DEFER doesn't count.
No, deferred probe is not counted.
Can you add a word somewhere in the comment(?) to make this clear?
--
With Best Regards,
Andy Shevchenko
More information about the dri-devel
mailing list