[PATCH v7 RESEND 3/3] drm/mediatek: Enable AR30 and BA30 overlays on MT8195

Chun-Kuang Hu chunkuang.hu at kernel.org
Wed Mar 8 23:35:23 UTC 2023


Hi, Justin:

Justin Green <greenjustin at chromium.org> 於 2023年3月8日 週三 下午11:34寫道:
>

Describe more about what and why this patch does. The other
modification looks good to me.

Regards,
Chun-Kuang.

> Tested using "modetest -P" on an MT8195 device.
>
> Signed-off-by: Justin Green <greenjustin at chromium.org>
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index a6255e847104..7d26f7055751 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -85,6 +85,22 @@ static const u32 mt8173_formats[] = {
>         DRM_FORMAT_YUYV,
>  };
>
> +static const u32 mt8195_formats[] = {
> +       DRM_FORMAT_XRGB8888,
> +       DRM_FORMAT_ARGB8888,
> +       DRM_FORMAT_ARGB2101010,
> +       DRM_FORMAT_BGRX8888,
> +       DRM_FORMAT_BGRA8888,
> +       DRM_FORMAT_BGRA1010102,
> +       DRM_FORMAT_ABGR8888,
> +       DRM_FORMAT_XBGR8888,
> +       DRM_FORMAT_RGB888,
> +       DRM_FORMAT_BGR888,
> +       DRM_FORMAT_RGB565,
> +       DRM_FORMAT_UYVY,
> +       DRM_FORMAT_YUYV,
> +};
> +
>  struct mtk_disp_ovl_data {
>         unsigned int addr;
>         unsigned int gmc_bits;
> @@ -616,8 +632,9 @@ static const struct mtk_disp_ovl_data mt8195_ovl_driver_data = {
>         .fmt_rgb565_is_0 = true,
>         .smi_id_en = true,
>         .supports_afbc = true,
> -       .formats = mt8173_formats,
> -       .num_formats = ARRAY_SIZE(mt8173_formats),
> +       .formats = mt8195_formats,
> +       .num_formats = ARRAY_SIZE(mt8195_formats),
> +       .supports_clrfmt_ext = true,
>  };
>
>  static const struct of_device_id mtk_disp_ovl_driver_dt_match[] = {
> --
> 2.39.1.456.gfc5497dd1b-goog
>


More information about the dri-devel mailing list