[PATCH 3/4] drm/msm/dpu: call _dpu_crtc_blend_setup_pipe for r_pipe

Abhinav Kumar quic_abhinavk at quicinc.com
Fri Mar 10 00:16:19 UTC 2023


_dpu_crtc_blend_setup_mixer() should call _dpu_crtc_blend_setup_pipe()
to stage the rectangles of the sspp for both the left and right
halves.

However, it incorrectly invokes it only for the left half causing
basic wide planes to not work and only half the screen is shown
on the display.

This was validated using a 2560x1440 DP monitor on sc7280 as
the max_linewidth is 2400 on sc7280.

Signed-off-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 03034ec8ed1b..b748c4f17c90 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -486,7 +486,7 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
 						   mixer, cstate->num_mixers,
 						   pstate->stage,
 						   format, fb ? fb->modifier : 0,
-						   &pstate->pipe, 1, stage_cfg);
+						   &pstate->r_pipe, 1, stage_cfg);
 		}
 
 		/* blend config update */
-- 
2.7.4



More information about the dri-devel mailing list