[PATCH] drm/mcde: Do not use dirty GEM FB handling

[Thomas Zimmermann]

Hi

Am 09.03.23 um 09:24 schrieb Linus Walleij:
> This driver has no way to handle damage, the reason the
> drm_gem_fb_create_with_dirty() was used was because I had the
> ambition that the driver would only send out updates to DSI
> command displays whenever something changed, so as to
> minimize traffic.
> 
> It turns out this ambition with command mode isn't working
> in practice because all the MCDE does is to create a
> continuous stream of DSI commands and while it is possible to
> send single frame updates with it, it's not been worthwhile.
> So we are just setting up continuous updates.
> 
> Reported-by: Thomas Zimmermann <tzimmermann at suse.de>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
> Thomas you can pick this as a prerequisite into your series
> or just ACK it and I will merge it into drm-misc-next so you
> can base your work on it.

I'll add the patch to my dma-fbdev series. Thanks a lot.

Best regards
Thomas

> ---
>   drivers/gpu/drm/mcde/mcde_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
> index 4aedb050d2a5..a592ad0d7886 100644
> --- a/drivers/gpu/drm/mcde/mcde_drv.c
> +++ b/drivers/gpu/drm/mcde/mcde_drv.c
> @@ -94,7 +94,7 @@
>   #define MCDE_PID_MAJOR_VERSION_MASK 0xFF000000
>   
>   static const struct drm_mode_config_funcs mcde_mode_config_funcs = {
> -	.fb_create = drm_gem_fb_create_with_dirty,
> +	.fb_create = drm_gem_fb_create,
>   	.atomic_check = drm_atomic_helper_check,
>   	.atomic_commit = drm_atomic_helper_commit,
>   };

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230310/7e4b4d03/attachment.sig>