[PATCH v4 2/8] kunit: drm/tests: move generic helpers

Stephen Boyd sboyd at kernel.org
Mon Mar 20 19:23:36 UTC 2023


Quoting Matti Vaittinen (2023-03-18 23:36:20)
> > 
> > I think you would have an easier time if you just copied and renamed
> > them into the kunit folder as an preparation series.
> 
> Yes. That would simplify the syncing between the trees. It slightly bugs 
> me to add dublicate code in kernel-but the clean-up series for DRM users 
> could be prepared at the same time. It would be even possible to just 
> change the drm-helper to be a wrapper for the generic one - and leave 
> the callers intact - although it leaves some seemingly unnecessary 
> "onion code" there.
> 
> > That way, you wouldn't have to coordinate DRM, CCF and IIO, you'd just
> > create new helpers that can be reused/converted to by everyone eventually
> 
> Yes. Thanks - I think I may go with this approach for the v5 :)

Which kunit directory? I imagine if there are conflicts they will be
trivial so it probably doesn't matter. Have you Cced kunit folks and the
list on the kunit patches? They may have some opinion.


More information about the dri-devel mailing list