[Intel-gfx] [PATCH v3] drm/i915/pxp: limit drm-errors or warning on firmware API failures

[Teres Alexis, Alan Previn]

On Fri, 2023-03-17 at 13:37 +0200, Tamminen, Eero T wrote:
> Hi,
> 
> On 16.3.2023 10.50, Tvrtko Ursulin wrote:
> > > [   11.674183] i915 0000:00:02.0: PXP init-arb-session-15 failed due 
> > > to BIOS/SOC:0x0000101a:ERR_PLATFORM_CONFIG
> ...
> > Alan - is this expected during normal operation on some parts, or it's 
> > something truly unexpected/unexplained? If the former then I think it 
> > would be good to downgrade away from drm_WARN so it is less scary.
> > 
> > Commit message talks about "HW/platform gaps" - if it is like a missing 
> > BIOS support or so then I think WARN_ON is too much.
> 
> Note that this was on pre-production TGL-H HW with BIOS from April 2021.
> 
> (I don't know where to get update, nor interested to update it.)
> 
> 
> 	- Eero

Alan: Hi Tvrtko, thanks for the feedback -i shall change from WARN_ONCE to drm_info_once.
Alan: snip