[PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running

Vinod Polimera quic_vpolimer at quicinc.com
Fri Mar 31 13:58:34 UTC 2023


In certain CPU stress conditions, there can be a delay in scheduling commit
work and it was observed that PSR commit from a different work queue was 
scheduled. Avoid these commits as display is already in PSR mode.

Signed-off-by: Vinod Polimera <quic_vpolimer at quicinc.com>
---
 drivers/gpu/drm/msm/msm_atomic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
index 645fe53..f8141bb 100644
--- a/drivers/gpu/drm/msm/msm_atomic.c
+++ b/drivers/gpu/drm/msm/msm_atomic.c
@@ -192,6 +192,9 @@ int msm_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
 			new_crtc_state->mode_changed = true;
 			state->allow_modeset = true;
 		}
+
+		if (old_crtc_state->self_refresh_active && new_crtc_state->self_refresh_active)
+			return -EINVAL;
 	}
 
 	return drm_atomic_helper_check(dev, state);
-- 
2.7.4



More information about the dri-devel mailing list