[PATCH] drm/udl: delete dead code

[Thomas Zimmermann]

Merged, thanks!

Am 02.05.23 um 14:59 schrieb Dan Carpenter:
> The "unode" pointer cannot be NULL here and checking for it causes
> Smatch warnings:
> 
>     drivers/gpu/drm/udl/udl_main.c:259 udl_get_urb_locked()
>     warn: can 'unode' even be NULL?
> 
> Fortunately, it's just harmless dead code which can be removed.  It's
> left over from commit c5c354a3a472 ("drm/udl: Fix inconsistent urbs.count
> value during udl_free_urb_list()").
> 
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
> ---
>   drivers/gpu/drm/udl/udl_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index 061cb88c08a2..3ebe2ce55dfd 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -255,7 +255,7 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout)
>   	list_del_init(&unode->entry);
>   	udl->urbs.available--;
>   
> -	return unode ? unode->urb : NULL;
> +	return unode->urb;
>   }
>   
>   #define GET_URB_TIMEOUT	HZ

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230503/56562e89/attachment.sig>