[PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h>

[Thomas Zimmermann]

Hi

Am 04.05.23 um 10:08 schrieb Arnd Bergmann:
> On Thu, May 4, 2023, at 09:45, Thomas Zimmermann wrote:
>> Fbdev provides helpers for framebuffer I/O, such as fb_readl(),
>> fb_writel() or fb_memcpy_to_fb(). The implementation of each helper
>> depends on the architecture, but they are all equivalent to regular
>> I/O functions of similar names. So use regular functions instead and
>> move all helpers into <asm-generic/fb.h>
>>
>> The first patch a simple whitespace cleanup.
>>
>> Until now, <linux/fb.h> contained an include of <asm/io.h>. As this
>> will go away, patches 2 to 4 prepare include statements in the various
>> drivers. Source files that use regular I/O helpers, such as readl(),
>> now include <linux/io.h>. Source files that use framebuffer I/O
>> helpers, such as fb_readl(), now include <linux/fb.h>.
>>
>> Patch 5 replaces the architecture-based if-else branching in
>> <linux/fb.h> by helpers in <asm-generic/fb.h>. All helpers use Linux'
>> existing I/O functions.
>>
>> Patch 6 harmonizes naming among fbdev and existing I/O functions.
>>
>> The patchset has been built for a variety of platforms, such as x86-64,
>> arm, aarch64, ppc64, parisc, m64k, mips and sparc.
> 
> The whole series looks good to me now,

This was a bit more effort to to untangle than I expected. Thanks for 
your help with cleaning this up.

Best regards
Thomas

> 
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230505/b4dad791/attachment.sig>