[PATCH] drm/exynos: g2d: staticize stubs in header

Alim Akhtar alim.akhtar at samsung.com
Sun May 7 16:35:45 UTC 2023


Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Sunday, May 7, 2023 8:18 PM
> To: Inki Dae <inki.dae at samsung.com>; Seung-Woo Kim
> <sw0312.kim at samsung.com>; Kyungmin Park
> <kyungmin.park at samsung.com>; David Airlie <airlied at gmail.com>; Daniel
> Vetter <daniel at ffwll.ch>; Krzysztof Kozlowski
> <krzysztof.kozlowski at linaro.org>; Alim Akhtar <alim.akhtar at samsung.com>;
> Marek Szyprowski <m.szyprowski at samsung.com>; dri-
> devel at lists.freedesktop.org; linux-arm-kernel at lists.infradead.org; linux-
> samsung-soc at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: [PATCH] drm/exynos: g2d: staticize stubs in header
> 
> Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> inline:
> 
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous
> prototype for ‘g2d_open’ [-Wmissing-prototypes]
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous
> prototype for ‘g2d_close’ [-Wmissing-prototypes]
> 
> Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar at samsung.com>


>  drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> index 74ea3c26dead..1a5ae781b56c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct
> drm_device *dev, void *data,
>  	return -ENODEV;
>  }
> 
> -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
>  {
>  	return 0;
>  }
> 
> -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
>  { }
>  #endif
> --
> 2.34.1





More information about the dri-devel mailing list