[PATCH 12/53] drm/bridge: nwl-dsi: Convert to platform remove callback returning void

[Laurent Pinchart]

Hi Uwe,

Thank you for the patch.

On Sun, May 07, 2023 at 06:25:35PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/nwl-dsi.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
> index 6dc2a4e191d7..4a5f5c4f5dcc 100644
> --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> @@ -1199,7 +1199,7 @@ static int nwl_dsi_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int nwl_dsi_remove(struct platform_device *pdev)
> +static void nwl_dsi_remove(struct platform_device *pdev)
>  {
>  	struct nwl_dsi *dsi = platform_get_drvdata(pdev);
>  
> @@ -1207,12 +1207,11 @@ static int nwl_dsi_remove(struct platform_device *pdev)
>  	mipi_dsi_host_unregister(&dsi->dsi_host);
>  	drm_bridge_remove(&dsi->bridge);
>  	pm_runtime_disable(&pdev->dev);
> -	return 0;
>  }
>  
>  static struct platform_driver nwl_dsi_driver = {
>  	.probe		= nwl_dsi_probe,
> -	.remove		= nwl_dsi_remove,
> +	.remove_new	= nwl_dsi_remove,
>  	.driver		= {
>  		.of_match_table = nwl_dsi_dt_ids,
>  		.name	= DRV_NAME,
> -- 
> 2.39.2
> 

-- 
Regards,

Laurent Pinchart