[PATCH 48/53] drm/tiny: Convert to platform remove callback returning void

[Thomas Zimmermann]

Hi,

the subject line is a bit ugly. You may want to change the it to say 
either 'drm/tiny/arcgpu' or just 'drm/arcgpu'. Same for the other 
tiny/-related patches.

Best regards
Thomas

Am 07.05.23 um 18:26 schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>   drivers/gpu/drm/tiny/arcpgu.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
> index 611bbee15071..a1f998a85ce8 100644
> --- a/drivers/gpu/drm/tiny/arcpgu.c
> +++ b/drivers/gpu/drm/tiny/arcpgu.c
> @@ -404,14 +404,12 @@ static int arcpgu_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int arcpgu_remove(struct platform_device *pdev)
> +static void arcpgu_remove(struct platform_device *pdev)
>   {
>   	struct drm_device *drm = platform_get_drvdata(pdev);
>   
>   	drm_dev_unregister(drm);
>   	arcpgu_unload(drm);
> -
> -	return 0;
>   }
>   
>   static const struct of_device_id arcpgu_of_table[] = {
> @@ -423,7 +421,7 @@ MODULE_DEVICE_TABLE(of, arcpgu_of_table);
>   
>   static struct platform_driver arcpgu_platform_driver = {
>   	.probe = arcpgu_probe,
> -	.remove = arcpgu_remove,
> +	.remove_new = arcpgu_remove,
>   	.driver = {
>   		   .name = "arcpgu",
>   		   .of_match_table = arcpgu_of_table,

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230508/9cbae483/attachment-0001.sig>