[PATCH 46/53] drm/tidss: Convert to platform remove callback returning void

[Tomi Valkeinen]

On 07/05/2023 19:26, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>   drivers/gpu/drm/tidss/tidss_drv.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

  Tomi

> diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
> index 2dac8727d2f4..13177d58c8f9 100644
> --- a/drivers/gpu/drm/tidss/tidss_drv.c
> +++ b/drivers/gpu/drm/tidss/tidss_drv.c
> @@ -197,7 +197,7 @@ static int tidss_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int tidss_remove(struct platform_device *pdev)
> +static void tidss_remove(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
>   	struct tidss_device *tidss = platform_get_drvdata(pdev);
> @@ -221,8 +221,6 @@ static int tidss_remove(struct platform_device *pdev)
>   	dispc_remove(tidss);
>   
>   	dev_dbg(dev, "%s done\n", __func__);
> -
> -	return 0;
>   }
>   
>   static void tidss_shutdown(struct platform_device *pdev)
> @@ -241,7 +239,7 @@ MODULE_DEVICE_TABLE(of, tidss_of_table);
>   
>   static struct platform_driver tidss_platform_driver = {
>   	.probe		= tidss_probe,
> -	.remove		= tidss_remove,
> +	.remove_new	= tidss_remove,
>   	.shutdown	= tidss_shutdown,
>   	.driver		= {
>   		.name	= "tidss",