[PATCH] accel/qaic: silence some uninitialized variable warnings

Jeffrey Hugo quic_jhugo at quicinc.com
Wed May 10 14:57:03 UTC 2023


On 5/3/2023 4:41 AM, Dan Carpenter wrote:
> Smatch complains that these are not initialized if get_cntl_version()
> fails but we still print them in the debug message.  Not the end of
> the world, but true enough.  Let's just initialize them to a dummy value
> to make the checker happy.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>

Thanks for the cleanup.

Reviewed-by: Jeffrey Hugo <quic_jhugo at quicinc.com>

Could use a fixes tag, and also I'd prefer to maintain the style of 
sorting the variable declaration lines by line length.  Given the minor 
nature of these nits, I plan to address them.


More information about the dri-devel mailing list