[PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

Linus Walleij linus.walleij at linaro.org
Mon May 15 09:30:40 UTC 2023


On Mon, May 15, 2023 at 11:26 AM Thomas Zimmermann <tzimmermann at suse.de> wrote:

> > I think I found this, the bandwidth limit calculation in
> > drivers/gpu/drm/pl111/pl111_display.c was using the bpp from
> > the config and this was decreased from 16 to 15 and as it determined
> > cpp by dividing bpp/8 this decreased from 2 bytes to 1 byte.
> >
> > Testing with DIV_ROUND_UP() in combination with the previous
> > fix!
>
> Great. It's the code in mode_valid, right? That fix should be good
> enough for now. In the long term, we could make some of the internal
> fb-helper code available to drivers. You'd then be able to use it to get
> the depth/bpp values for the color mode.

Yeah I sent a patch, check it out!

Yours,
Linus Walleij


More information about the dri-devel mailing list