[PATCH 18/53] drm/exynos: Convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri May 19 06:38:29 UTC 2023


Hello Inki Dae,

On Fri, May 19, 2023 at 09:11:58AM +0900, 대인기 wrote:
> > On Mon, May 15, 2023 at 04:32:00PM +0900, Inki Dae wrote:
> > > 2023년 5월 8일 (월) 오전 1:27, Uwe Kleine-König <u.kleine-
> > koenig at pengutronix.de>님이 작성:
> > > Could you please update exynos_drm_vidi.c also? Seems you missed.
> > 
> > This one cannot be trivially converted as vidi_remove() doensn't return
> > zero in all cases. I didn't grok the details about ctx->raw_edid and
> > don't know if skipping component_del() is right or not.
> > 
> > If you know the driver, feel free to address this.
> 
> I just posted one patch[1] which drops error return line from vidi_remove() because it's not an error case so it shouldn't return an error.
> If you subscribed dri-devel then the patch must be in your mail box. On top of this, you could update it.

I'm not subscribed, but I'll care to convert the driver once your patch
has landed in the mainline.

Thanks for the assist,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230519/b57f98b7/attachment.sig>


More information about the dri-devel mailing list