[PATCH] drm/gma500: Clear fbdev framebuffer with fb_memset_io()

[Thomas Zimmermann]

Hi

Am 23.05.23 um 09:00 schrieb Patrik Jakobsson:
> On Mon, May 22, 2023 at 09:06:37PM +0200, Thomas Zimmermann wrote:
>> The fbdev framebuffer is I/O memory, so clear it with fb_memset_io().
>> Fixes the following sparse warning:
>>
>> ../drivers/gpu/drm/gma500/fbdev.c:234:20: warning: incorrect type in argument 1 (different address spaces)
>> ../drivers/gpu/drm/gma500/fbdev.c:234:20:    expected void *s
>> ../drivers/gpu/drm/gma500/fbdev.c:234:20:    got char [noderef] __iomem *screen_base
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> 
> Looks good but I don't see the fb_mem*() helper change being merged yet.
> Or am I looking in the wrong place?

It's here, in drm-misc-next:

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=20d54e48d9c705091a025afff5839da2ea606f6b

The patch would go there as well.

Best regards
Thomas

> 
>> ---
>>   drivers/gpu/drm/gma500/fbdev.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
>> index 62287407e717..4f0309548b2b 100644
>> --- a/drivers/gpu/drm/gma500/fbdev.c
>> +++ b/drivers/gpu/drm/gma500/fbdev.c
>> @@ -231,7 +231,7 @@ static int psb_fbdev_fb_probe(struct drm_fb_helper *fb_helper,
>>   	info->fix.mmio_start = pci_resource_start(pdev, 0);
>>   	info->fix.mmio_len = pci_resource_len(pdev, 0);
>>   
>> -	memset(info->screen_base, 0, info->screen_size);
>> +	fb_memset_io(info->screen_base, 0, info->screen_size);
>>   
>>   	/* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
>>   
>> -- 
>> 2.40.1
>>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230523/4e6d428d/attachment.sig>