[PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support"

Johan Hovold johan+linaro at kernel.org
Tue May 23 15:16:46 UTC 2023


This reverts commit 1844e680d56bb0c4e0489138f2b7ba2dc1c988e3.

PSR support clearly is not ready for mainline and specifically breaks
virtual terminals which are no longer updated when PSR is enabled (e.g.
no keyboard input is echoed, no cursor blink).

Disable PSR support for now by reverting commit 1844e680d56b
("drm/msm/dp: set self refresh aware based on PSR support").

Cc: Vinod Polimera <quic_vpolimer at quicinc.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
Signed-off-by: Johan Hovold <johan+linaro at kernel.org>
---

Bjorn reported that PSR support broke virtual terminals two months ago, 
but this is still broken in 6.4-rc3:

	https://lore.kernel.org/lkml/20230326162723.3lo6pnsfdwzsvbhj@ripper/

despite the following series that claimed to address this:

	https://lore.kernel.org/lkml/1680271114-1534-1-git-send-email-quic_vpolimer@quicinc.com

Let's revert until this has been fixed properly.

Johan


 drivers/gpu/drm/msm/dp/dp_drm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index 785d76639497..029e08c5bb06 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -117,8 +117,6 @@ static int edp_bridge_atomic_check(struct drm_bridge *drm_bridge,
 	if (WARN_ON(!conn_state))
 		return -ENODEV;
 
-	conn_state->self_refresh_aware = dp->psr_supported;
-
 	if (!conn_state->crtc || !crtc_state)
 		return 0;
 
-- 
2.39.3



More information about the dri-devel mailing list