[Freedreno] [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

Abhinav Kumar quic_abhinavk at quicinc.com
Wed May 24 23:04:33 UTC 2023



On 5/24/2023 3:46 PM, Abhinav Kumar wrote:
> 
> 
> On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote:
>> In preparation to virtualized planes support, move pstate->pipe
>> initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In
>> case of virtual planes the plane's pipe will not be known up to the
>> point of atomic_check() callback.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> ---
> 
> Will legacy paths be broken with this? So lets say there is no 
> atomic_check we will not have a valid sspp anymore.

I think it should still work, even if goes through the modeset crtc, it 
should still call drm_atomic_commit() internally which should have the 
call to atomic_check, once you confirm this , i can ack this particular 
change.


More information about the dri-devel mailing list