[PATCH 00/51] video: fbdev: Convert to platform remove callback returning void

[Helge Deller]

Hi Uwe,

On 5/30/23 16:02, Uwe Kleine-König wrote:
> On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote:
>> On 3/19/23 00:53, Uwe Kleine-König wrote:
>>> this series adapts the platform drivers below drivers/video/fbdev to use the
>>> .remove_new() callback. Compared to the traditional .remove() callback
>>> .remove_new() returns no value. This is a good thing because the driver core
>>> doesn't (and cannot) cope for errors during remove. The only effect of a
>>> non-zero return value in .remove() is that the driver core emits a warning. The
>>> device is removed anyhow and an early return from .remove() usually yields a
>>> resource leak.
>>>
>>> By changing the remove callback to return void driver authors cannot
>>> reasonably assume any more that there is some kind of cleanup later.
>>>
>>> The first patch simplifies the remove callback of one driver to obviously
>>> always return zero. After that all drivers are converted trivially to
>>> .remove_new().
>>
>> Thanks for that patch series. It's a nice cleanup.
>> I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
>> I hope that's ok for you.
>
> I found patches #7 up to #51 in next, but the first 6 patches are
> missing. I guess this wasn't' done on purpose?

Strange. I don't know why I didn't applied those.

Anyway, I've just added them now:

Applying: video: fbdev: au1100fb: Drop if with an always false condition
Applying: video: fbdev: arcfb: Convert to platform remove callback returning void
Applying: video: fbdev: au1100fb: Convert to platform remove callback returning void
Applying: video: fbdev: au1200fb: Convert to platform remove callback returning void
Applying: video: fbdev: broadsheetfb: Convert to platform remove callback returning void
Applying: video: fbdev: bw2: Convert to platform remove callback returning void

Thanks!
Helge

Btw... I cleaned up some minor whitespace issues in patch 3 (au1100fb).