[PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

[Bjorn Andersson]

On Wed, May 31, 2023 at 09:28:35AM +0200, Johan Hovold wrote:
> On Tue, May 30, 2023 at 08:09:44PM -0700, Bjorn Andersson wrote:
> > From: Bjorn Andersson <bjorn.andersson at linaro.org>
> > 
> > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the
> > SC8280XP.
> > 
> > Tested-by: Steev Klimaszewski <steev at kali.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson at linaro.org>
> > Signed-off-by: Bjorn Andersson <quic_bjorande at quicinc.com>
> > ---
> > 
> > Changes since v2:
> > - Added missing opp level (both gpu and gmu)
> > - Corrected opp-level for highest gpu opp
> > - Added dma-coherent to gpu smmu
> > 
> > Note that in order for the GPU driver to probe, the last change
> > requires:
> > https://lore.kernel.org/linux-arm-msm/20230410185226.3240336-1-dmitry.baryshkov@linaro.org/
> 
> That's a pretty well-hidden notice about a critical dependency. I just
> spent the morning debugging why this series broke the probe of the GPU
> and only saw this when I was going to report my findings.
> 
> Please consider putting information like this in the cover letter in the
> future.
> 
> > Changes since v1:
> > - Dropped gmu_pdc_seq region from &gmu, as it shouldn't have been used.
> > - Added missing compatible to &adreno_smmu.
> > - Dropped aoss_qmp clock in &gmu and &adreno_smmu.
> 
> Changelogs are also preferably placed in the cover letter so that you
> don't have to read through N patches to determine what changed from one
> revision of a series to the next.
> 

I've always put the changelog in the patches. But I can see the value of
using the cover-letter for that purpose. I will consider doing so...

Regards,
Bjorn