[PATCH] dt-bindings: samsung,mipi-dsim: Use port-base reference

[Krzysztof Kozlowski]

On 31/05/2023 03:43, Fabio Estevam wrote:
> From: Fabio Estevam <festevam at denx.de>
> 
> Use port-base reference for port at 0 and port at 1.
> 
> This fixes the following schema warning:
> 
> imx8mm-evk.dtb: dsi at 32e10000: ports:port at 1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
> From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> 
> Fixes: 1f0d40d88f7a ("dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml")

No, you change correct binding into incorrect to hide warning, instead
of fixing root cause.

> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
>  .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> index 9f61ebdfefa8..51879030dd6d 100644
> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> @@ -93,14 +93,14 @@ properties:
>  
>      properties:
>        port at 0:
> -        $ref: /schemas/graph.yaml#/properties/port
> +        $ref: /schemas/graph.yaml#/$defs/port-base

No, because you allow now anything here.

>          description:
>            Input port node to receive pixel data from the
>            display controller. Exactly one endpoint must be
>            specified.
>  
>        port at 1:
> -        $ref: /schemas/graph.yaml#/properties/port
> +        $ref: /schemas/graph.yaml#/$defs/port-base

This would have sense if you kept original intention, so
additionalProperties: false

Without it - you just break bindings to hide warning.



Best regards,
Krzysztof