[PATCH net-next v5 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller
Florian Fainelli
florian.fainelli at broadcom.com
Wed May 31 21:32:59 UTC 2023
On 5/24/23 16:01, Justin Chen wrote:
> Add support for the Broadcom ASP 2.0 Ethernet controller which is first
> introduced with 72165. This controller features two distinct Ethernet
> ports that can be independently operated.
>
> This patch supports:
>
> - Wake-on-LAN using magic packets
> - basic ethtool operations (link, counters, message level)
> - MAC destination address filtering (promiscuous, ALL_MULTI, etc.)
>
> Reviewed-by: Simon Horman <simon.horman at corigine.com>
> Signed-off-by: Florian Fainelli <florian.fainelli at broadcom.com>
> Signed-off-by: Justin Chen <justin.chen at broadcom.com>
> ---
[snip]
> +static const struct net_device_ops bcmasp_netdev_ops = {
> + .ndo_open = bcmasp_open,
> + .ndo_stop = bcmasp_stop,
> + .ndo_start_xmit = bcmasp_xmit,
> + .ndo_tx_timeout = bcmasp_tx_timeout,
> + .ndo_set_rx_mode = bcmasp_set_rx_mode,
> + .ndo_get_phys_port_name = bcmasp_get_phys_port_name,
> + .ndo_get_stats = bcmasp_get_stats,
> + .ndo_do_ioctl = bcmasp_ioctl,
This needs to be:
@@ -1207,7 +1196,7 @@ static const struct net_device_ops
bcmasp_netdev_ops = {
.ndo_set_rx_mode = bcmasp_set_rx_mode,
.ndo_get_phys_port_name = bcmasp_get_phys_port_name,
.ndo_get_stats = bcmasp_get_stats,
- .ndo_do_ioctl = bcmasp_ioctl,
+ .ndo_eth_ioctl = phy_do_ioctl_running,
.ndo_set_mac_address = bcmasp_set_mac_address,
};
such that MII ioctls work properly.
--
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230531/9e3e15b6/attachment.bin>
More information about the dri-devel
mailing list