[PATCH v3 07/16] drm/etnaviv: Convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Nov 2 17:05:53 UTC 2023


Hello,

On Thu, Nov 02, 2023 at 05:56:48PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert the etnaviv drm driver from always returning zero in
> the remove callback to the void returning variant.
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>
> Reviewed-by: Jyri Sarha <jyri.sarha at iki.fi>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

I failed to pick up the tag

Reviewed-by: Christian Gmeiner <cgmeiner at igalia.com>

that this patch got in v2 at https://lore.kernel.org/dri-devel/CAH9NwWdzVPrZD3Uo04fWXR0Cv=okK+P+njAR81gprCxKqp5icw@mail.gmail.com

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20231102/49c8db6c/attachment.sig>


More information about the dri-devel mailing list