[PATCH v2 3/4] drm/modes: Add a function to clear preferred modes

Doug Anderson dianders at chromium.org
Fri Nov 3 16:02:33 UTC 2023


Hi,

On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang <hsinyi at chromium.org> wrote:
>
> Add a function to clear the preferred bit of a connector's existing modes.
> This is useful for edp panel to unset the preferred modes read from edid
> if the panel has hard-coded modes.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi at chromium.org>
> ---
> v1->v2:
> - fix doc string (reported by kernel test robot).
> - split mode and panel patches.
> ---
>  drivers/gpu/drm/drm_modes.c | 16 ++++++++++++++++
>  include/drm/drm_modes.h     |  1 +
>  2 files changed, 17 insertions(+)

This seems fine to me.

Reviewed-by: Douglas Anderson <dianders at chromium.org>

Since it introduces a new API to the core and Hsin-Yi and I work
directly together, I'd probably give this ~2 weeks on the list before
landing so there is adequate time for people to comment. That'll be
right in the middle of Plumbers, though, so it might be more like 3
weeks. If someone non-ChromeOS wants to review and/or apply sooner, I
certainly wouldn't object.


More information about the dri-devel mailing list