回复: [PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit

[oushixiong at kylinos.cn]

Hi,  
I think it will cause memory leaks if too many nonblock commit works return
-EBUSY.
You can try to send large number of nonblock commits by
drmModeAtomicCommit().

-----邮件原件-----
发件人: Maxime Ripard <mripard at kernel.org> 
发送时间: 2023年11月6日 18:33
收件人: oushixiong <oushixiong at kylinos.cn>
抄送: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>; Thomas
Zimmermann <tzimmermann at suse.de>; David Airlie <airlied at gmail.com>; Daniel
Vetter <daniel at ffwll.ch>; dri-devel at lists.freedesktop.org;
linux-kernel at vger.kernel.org
主题: Re: [PATCH] drm/atomic-helper: Call stall_checks() before allocate
drm_crtc_commit

Hi,

On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote:
> From: Shixiong Ou <oushixiong at kylinos.cn>
> 
> Calling stall_checks() before allocating drm_crtc_commit not after that.
> 
> Signed-off-by: Shixiong Ou <oushixiong at kylinos.cn>

Generally speaking, we need much more context than that.

What bug did you encounter that makes you say that it should be moved?
How can we reproduce it? How long has that issue been in the code? What
makes you say that this is the right solution?

Maxime