[PATCH] Revert "drm/sched: Define pr_fmt() for DRM using pr_*()"

Javier Martinez Canillas javierm at redhat.com
Sat Nov 11 08:56:18 UTC 2023


Luben Tuikov <ltuikov89 at gmail.com> writes:

Hello Luben,

> From Jani:
> The drm_print.[ch] facilities use very few pr_*() calls directly. The
> users of pr_*() calls do not necessarily include <drm/drm_print.h> at
> all, and really don't have to.
>
> Even the ones that do include it, usually have <linux/...> includes
> first, and <drm/...> includes next. Notably, <linux/kernel.h> includes
> <linux/printk.h>.
>
> And, of course, <linux/printk.h> defines pr_fmt() itself if not already
> defined.
>
> No, it's encouraged not to use pr_*() at all, and prefer drm device
> based logging, or device based logging.
>

Thanks for including the rationale from Jani for the revert.

> This reverts commit 36245bd02e88e68ac5955c2958c968879d7b75a9.
>
> Signed-off-by: Luben Tuikov <ltuikov89 at gmail.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/878r75wzm9.fsf@intel.com
> ---

Acked-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list