[PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support
Andy Yan
andy.yan at rock-chips.com
Wed Nov 15 02:45:25 UTC 2023
On 11/15/23 05:54, Heiko Stübner wrote:
> Am Dienstag, 14. November 2023, 12:28:41 CET schrieb Andy Yan:
>> From: Andy Yan <andy.yan at rock-chips.com>
>>
>> The vop2 on rk3588 is similar to which on rk356x
>> but with 4 video outputs and need to reference
>> more grf modules.
>>
>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>> ---
>>
>> .../display/rockchip/rockchip-vop2.yaml | 25 +++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> index b60b90472d42..c333c651da1a 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> @@ -20,6 +20,7 @@ properties:
>> enum:
>> - rockchip,rk3566-vop
>> - rockchip,rk3568-vop
>> + - rockchip,rk3588-vop
>>
>> reg:
>> items:
>> @@ -48,6 +49,8 @@ properties:
>> - description: Pixel clock for video port 0.
>> - description: Pixel clock for video port 1.
>> - description: Pixel clock for video port 2.
>> + - description: Pixel clock for video port 4.
>> + - description: Peripheral clock for vop on rk3588.
>>
>> clock-names:
>> items:
>> @@ -56,12 +59,29 @@ properties:
>> - const: dclk_vp0
>> - const: dclk_vp1
>> - const: dclk_vp2
>> + - const: dclk_vp3
>> + - const: pclk_vop
> with the error Rob's bot reported, I guess both clocks and clock-names
> need a minItems element to mark these new clocks essentially as optional?
Yes, when add minItems for clocks and clkock-names, the erro gone.
Considering we also have vop2 based soc(rk3562) only have one video port,
so it is better to set the minItems as 3 here?
>
>> rockchip,grf:
>> $ref: /schemas/types.yaml#/definitions/phandle
>> description:
>> Phandle to GRF regs used for misc control
>>
>> + rockchip,vo-grf:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to VO GRF regs used for misc control, required for rk3588
>> +
>> + rockchip,vop-grf:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to VOP GRF regs used for misc control, required for rk3588
>> +
>> + rockchip,pmu:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to PMU regs used for misc control, required for rk3588
>> +
>> ports:
>> $ref: /schemas/graph.yaml#/properties/ports
>>
>> @@ -81,6 +101,11 @@ properties:
>> description:
>> Output endpoint of VP2
>>
>> + port at 3:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description:
>> + Output endpoint of VP3
>> +
>> iommus:
>> maxItems: 1
>>
>>
>
>
>
More information about the dri-devel
mailing list