[PATCH 21/32] fbdev/clps711x-fb: Initialize fb_ops with fbdev macros
Javier Martinez Canillas
javierm at redhat.com
Thu Nov 16 11:28:25 UTC 2023
Thomas Zimmermann <tzimmermann at suse.de> writes:
> Initialize the instance of struct fb_ops with fbdev initializer
> macros for framebuffers in I/O address space. Set the read/write,
> draw and mmap callbacks to the correct implementation and avoid
> implicit defaults. Also select the necessary helpers in Kconfig.
>
> The driver previously selected drawing ops for system memory
> although it operates on I/O memory. Fixed now.
>
> Fbdev drivers sometimes rely on the callbacks being NULL for a
> default I/O-memory-based implementation to be invoked; hence
> requiring the I/O helpers to be built in any case. Setting all
> callbacks in all drivers explicitly will allow to make the I/O
> helpers optional. This benefits systems that do not use these
> functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the dri-devel
mailing list