[PATCH 25/32] staging/sm750fb: Declare fb_ops as constant

Javier Martinez Canillas javierm at redhat.com
Thu Nov 16 11:44:42 UTC 2023


Thomas Zimmermann <tzimmermann at suse.de> writes:

> Split up lynxfb_ops and declare each as constant. The fb_ops
> instance used to be modified while initializing the driver. It is
> now constant and the driver picks the correct instance, depending
> on the settings for acceleration and cursor support.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Sudip Mukherjee <sudipm.mukherjee at gmail.com>
> Cc: Teddy Wang <teddy.wang at siliconmotion.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: linux-staging at lists.linux.dev
> ---
>  drivers/staging/sm750fb/sm750.c | 59 +++++++++++++++++++++++++++------
>  1 file changed, 49 insertions(+), 10 deletions(-)
>

Same than patch patch #6, the change is less trivial and would be great if
someone with the hardware can test/review. But the patch looks good to me:

Acked-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list