[Intel-gfx] [PATCH] drm/i915/irq: Improve error logging for unexpected DE Misc interrupts

[Rahul Rameshbabu]

On Thursday, November 23rd, 2023 at 11:54 PM, Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com> wrote:
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Rahul
> > Rameshbabu
> > Sent: Thursday, November 23, 2023 11:27 PM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Nikula, Jani <jani.nikula at intel.com>; dri-devel at lists.freedesktop.org;
> > Rahul Rameshbabu <sergeantsagara at protonmail.com>
> > Subject: [Intel-gfx] [PATCH] drm/i915/irq: Improve error logging for
> > unexpected DE Misc interrupts
> > 
> > Dump the iir value in hex when the interrupt is unexpected.
> > 
> > Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9652#note_2178501
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Signed-off-by: Rahul Rameshbabu <sergeantsagara at protonmail.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c
> > b/drivers/gpu/drm/i915/display/intel_display_irq.c
> > index bff4a76310c0..1a5a9e0fc01e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> > @@ -896,7 +896,7 @@ gen8_de_misc_irq_handler(struct drm_i915_private
> > *dev_priv, u32 iir)
> > }
> > 
> > if (!found)
> > - drm_err(&dev_priv->drm, "Unexpected DE Misc
> > interrupt\n");
> > + drm_err(&dev_priv->drm, "Unexpected DE Misc interrupt:
> > %#x\n", iir);
> 
> 
> Nit: It could use a format specifier like "0x%08x" (like other instances in the file) to maintain uniform width.

Agreed. I made this change initially for debugging without actually checking the practices used in the file.
Will send a v2 with this change and your Reviewed-by tag soon. Away from my development machine right now.

> Other than that. LGTM.
> 
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>

--
Thanks,

Rahul Rameshbabu