[bug report] drm/imagination: Implement firmware infrastructure and META FW support

Dan Carpenter dan.carpenter at linaro.org
Thu Nov 30 07:27:26 UTC 2023


Hello Sarah Walker,

The patch cc1aeedb98ad: "drm/imagination: Implement firmware
infrastructure and META FW support" from Nov 22, 2023 (linux-next),
leads to the following Smatch static checker warning:

	drivers/gpu/drm/imagination/pvr_ccb.c:277 pvr_kccb_send_cmd_reserved_powered()
	warn: odd binop '0x0 & 0xf'

drivers/gpu/drm/imagination/pvr_ccb.c
    268                 WRITE_ONCE(pvr_dev->kccb.rtn[old_write_offset],
    269                            ROGUE_FWIF_KCCB_RTN_SLOT_NO_RESPONSE);
    270         }
    271         mb(); /* memory barrier */
    272         WRITE_ONCE(ctrl->write_offset, new_write_offset);
    273         pvr_dev->kccb.reserved_count--;
    274 
    275         /* Kick MTS */
    276         pvr_fw_mts_schedule(pvr_dev,
--> 277                             PVR_FWIF_DM_GP & ~ROGUE_CR_MTS_SCHEDULE_DM_CLRMSK);
                                    ^^^^^^^^^^^^^^
PVR_FWIF_DM_GP is zero.

    278 
    279 out_unlock:
    280         mutex_unlock(&pvr_ccb->lock);
    281 }

regards,
dan carpenter


More information about the dri-devel mailing list