[PATCH] video: fbdev: arkfb: fix possible object reference leak

Zhang Shurong zhang_shurong at foxmail.com
Thu Oct 5 07:01:41 UTC 2023


Add missing pci_disable_device() in error path in ark_pci_probe().

Signed-off-by: Zhang Shurong <zhang_shurong at foxmail.com>
---
 drivers/video/fbdev/arkfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
index 60a96fdb5dd8..6c4e5065646f 100644
--- a/drivers/video/fbdev/arkfb.c
+++ b/drivers/video/fbdev/arkfb.c
@@ -1064,7 +1064,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 err_dac:
 	pci_release_regions(dev);
 err_request_regions:
-/*	pci_disable_device(dev); */
+	pci_disable_device(dev);
 err_enable_device:
 	framebuffer_release(info);
 	return rc;
@@ -1085,7 +1085,7 @@ static void ark_pci_remove(struct pci_dev *dev)
 
 		pci_iounmap(dev, info->screen_base);
 		pci_release_regions(dev);
-/*		pci_disable_device(dev); */
+		pci_disable_device(dev);
 
 		framebuffer_release(info);
 	}
-- 
2.30.2



More information about the dri-devel mailing list