[PATCH 1/3] drm/rockchip: remove unused struct in vop2

Sascha Hauer s.hauer at pengutronix.de
Fri Oct 13 06:13:45 UTC 2023


On Thu, Oct 12, 2023 at 10:36:53AM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan at rock-chips.com>
> 
> These structs are undefined and un used.
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> 
> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>

Reviewed-by: Sascha Hauer <s.hauer at pengutronix.de>

Sascha

> 
> ---
> 
>  drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 --
>  drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 3 ---
>  2 files changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 583df4d22f7e..3c524ca23d53 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -160,7 +160,6 @@ struct vop2_video_port {
>  	struct vop2 *vop2;
>  	struct clk *dclk;
>  	unsigned int id;
> -	const struct vop2_video_port_regs *regs;
>  	const struct vop2_video_port_data *data;
>  
>  	struct completion dsp_hold_completion;
> @@ -2274,7 +2273,6 @@ static int vop2_create_crtcs(struct vop2 *vop2)
>  		vp = &vop2->vps[i];
>  		vp->vop2 = vop2;
>  		vp->id = vp_data->id;
> -		vp->regs = vp_data->regs;
>  		vp->data = vp_data;
>  
>  		snprintf(dclk_name, sizeof(dclk_name), "dclk_vp%d", vp->id);
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h
> index f1234a151130..56fd31e05238 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h
> @@ -134,16 +134,13 @@ struct vop2_video_port_data {
>  	u16 cubic_lut_len;
>  	struct vop_rect max_output;
>  	const u8 pre_scan_max_dly[4];
> -	const struct vop2_video_port_regs *regs;
>  	unsigned int offset;
>  };
>  
>  struct vop2_data {
>  	u8 nr_vps;
> -	const struct vop2_ctrl *ctrl;
>  	const struct vop2_win_data *win;
>  	const struct vop2_video_port_data *vp;
> -	const struct vop_csc_table *csc_table;
>  	struct vop_rect max_input;
>  	struct vop_rect max_output;
>  
> -- 
> 2.34.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


More information about the dri-devel mailing list