[PATCH v5 6/7] drm/ssd130x: Fix atomic_check for disabled planes

[Javier Martinez Canillas]

Thomas Zimmermann <tzimmermann at suse.de> writes:

Hello Thomas,

> The plane's atomic_check returns -EINVAL if the CRTC has not been
> set. This is the case for disabled planes, for which atomic_check
> should return 0. For disabled planes, it also omits the mandatory
> call to drm_atomic_helper_check_plane_state().
>
> Replace the test with the boiler-plate code that first invokes
> drm_atomic_helper_check_plane_state() and then tests for the plane
> to be visible. Return early for non-visible planes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Fixes: d51f9fbd98b6 ("drm/ssd130x: Store the HW buffer in the driver-private CRTC state")
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> Tested-by: Javier Martinez Canillas <javierm at redhat.com>
> Cc: Geert Uytterhoeven <geert at linux-m68k.org>
> Cc: Javier Martinez Canillas <javierm at redhat.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> ---

I've picked this since it's an unrelated fix to the rest of the series.

Pushed to drm-misc (drm-misc-next) because the offending commit is not
in mainline yet. Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat