[PATCH v7 4/6] drm/i915/panelreplay: Enable panel replay dpcd initialization for DP

[Murthy, Arun R]

> -----Original Message-----
> From: Manna, Animesh <animesh.manna at intel.com>
> Sent: Wednesday, October 11, 2023 4:40 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: dri-devel at lists.freedesktop.org; Manna, Animesh
> <animesh.manna at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>;
> Murthy, Arun R <arun.r.murthy at intel.com>; Nikula, Jani
> <jani.nikula at intel.com>
> Subject: [PATCH v7 4/6] drm/i915/panelreplay: Enable panel replay dpcd
> initialization for DP
> 
> Due to similarity panel replay dpcd initialization got added in psr function which
> is specific for edp panel. This patch enables panel replay initialization for dp
> connector.
> 
If panelreplay initialization then why is the function name psr_init_dpcd() ?
Also it its similar to PSR then these dpcd should already be available.

Thanks and Regards,
Arun R Murthy
--------------------

> Cc: Jouni Högander <jouni.hogander at intel.com>
> Cc: Arun R Murthy <arun.r.murthy at intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Signed-off-by: Animesh Manna <animesh.manna at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index f9837001aa5f..a2e0637c53fb 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -2738,6 +2738,9 @@ void intel_psr_init(struct intel_dp *intel_dp)
>  	if (!(HAS_PSR(dev_priv) || HAS_DP20(dev_priv)))
>  		return;
> 
> +	if (!intel_dp_is_edp(intel_dp))
> +		intel_psr_init_dpcd(intel_dp);
> +
>  	/*
>  	 * HSW spec explicitly says PSR is tied to port A.
>  	 * BDW+ platforms have a instance of PSR registers per transcoder but
> --
> 2.29.0