[Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Create the guc_to_i915() wrapper

Andi Shyti andi.shyti at linux.intel.com
Wed Oct 25 14:53:52 UTC 2023


Hi Nirmoy,

> > +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc)
> > +{
> > +	return guc_to_gt(guc)->i915;
> > +}
> > +
> 
> We don't want inline functions in headers files[1]. Otherwise the series
> looks fine to me:

the reason for that patch is that we were including the
i915_drv.h just for that inline function and we were doing it
inside the gt/.

In this patch I am not changing any header dependency.

I guess the original idea from Matt was to have a generic network
of intel_gt_needs_wa_xxx(), but it didn't develop further.

> Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

Thanks,
Andi


More information about the dri-devel mailing list